sjperkins commented on issue #36446: URL: https://github.com/apache/arrow/issues/36446#issuecomment-1620617266
> Using `std::move` on a constant lvalue reference might not causing a bug, because it might just copy the vector. But it's worthing to fix it. Yes you're right, I'd forgotten that std::move instructs the compiler to try a move, but it's not guaranteed. This SO explains it well https://stackoverflow.com/a/28595207. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
