kou commented on code in PR #36296:
URL: https://github.com/apache/arrow/pull/36296#discussion_r1252680993
##########
docs/source/developers/java/building.rst:
##########
@@ -195,7 +195,7 @@ CMake
- To build all JNI libraries (MacOS / Linux) except the JNI C Data Interface
library:
- .. code-block::
+ .. code-block:: text
Review Comment:
Oh...
Does the following change solve it?
```diff
diff --git a/docs/source/developers/java/building.rst
b/docs/source/developers/java/building.rst
index c400b95f2..e8a499d1c 100644
--- a/docs/source/developers/java/building.rst
+++ b/docs/source/developers/java/building.rst
@@ -203,7 +203,7 @@ CMake
$ brew uninstall aws-sdk-cpp
(We can't use aws-sdk-cpp installed by Homebrew because it has
an issue: https://github.com/aws/aws-sdk-cpp/issues/1809 )
- $ export JAVA_HOME=<absolute path to your java home>
+ $ export JAVA_HOME=${ABSOLUTE_PATH_TO_YOUR_JAVA_HOME}
$ mkdir -p java-dist cpp-jni
$ cmake \
-S cpp \
@@ -221,7 +221,7 @@ CMake
-DARROW_S3=ON \
-DARROW_USE_CCACHE=ON \
-DCMAKE_BUILD_TYPE=Release \
- -DCMAKE_INSTALL_LIBDIR=lib/<your system's architecture> \
+ -DCMAKE_INSTALL_LIBDIR=lib/${YOUR_SYSTEM_ARCHITECTURE} \
-DCMAKE_INSTALL_PREFIX=java-dist \
-DCMAKE_UNITY_BUILD=ON
$ cmake --build cpp-jni --target install --config Release
@@ -232,11 +232,11 @@ CMake
-DARROW_JAVA_JNI_ENABLE_DEFAULT=ON \
-DBUILD_TESTING=OFF \
-DCMAKE_BUILD_TYPE=Release \
- -DCMAKE_INSTALL_LIBDIR=lib/<your system's architecture> \
+ -DCMAKE_INSTALL_LIBDIR=lib/${YOUR_SYSTEM_ARCHITECTURE} \
-DCMAKE_INSTALL_PREFIX=java-dist \
-DCMAKE_PREFIX_PATH=$PWD/java-dist
$ cmake --build java-jni --target install --config Release
- $ ls -latr java-dist/lib/<your system's architecture>/*_{jni,java}.*
+ $ ls -latr java-dist/lib/${YOUR_SYSTEM_ARCHITECTURE}/*_{jni,java}.*
|__ libarrow_dataset_jni.dylib
|__ libarrow_orc_jni.dylib
|__ libgandiva_jni.dylib
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
