jorisvandenbossche commented on code in PR #36290:
URL: https://github.com/apache/arrow/pull/36290#discussion_r1254474757
##########
python/pyarrow/_parquet.pyx:
##########
@@ -1599,6 +1610,14 @@ cdef shared_ptr[WriterProperties]
_create_writer_properties(
# a size larger than this then it will be latched to this value.
props.max_row_group_length(_MAX_ROW_GROUP_SIZE)
+ # page index
+
+ if isinstance(write_page_index, bool):
Review Comment:
I think this pattern comes from the code above, where such isinstance check
is also used. But that's for cases where the keyword could either be True/False
or a dictionary to enable the option per column.
Here it's just a single True/False, so indeed the check is not needed.
I think we can simply leave out the `if isinstance` and just have the ``if
write_page_index: ... else: ...``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
