zeroshade commented on code in PR #36489:
URL: https://github.com/apache/arrow/pull/36489#discussion_r1254565274
##########
cpp/src/arrow/buffer.h:
##########
@@ -57,18 +57,25 @@ class ARROW_EXPORT Buffer {
///
/// \note The passed memory must be kept alive through some other means
Buffer(const uint8_t* data, int64_t size)
- : is_mutable_(false), is_cpu_(true), data_(data), size_(size),
capacity_(size) {
+ : is_mutable_(false), is_cpu_(true), data_(data), size_(size),
capacity_(size), device_type_(DeviceType::CPU) {
Review Comment:
The `is_cpu_` boolean is still useful because of pinned host memory. Both
`CUDA_HOST` and `ROCM_HOST` are pinned CPU memory which would have the
corresponding device type (since the memory is managed by the device drivers)
but is accessible to the CPU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
