eerhardt commented on code in PR #35810:
URL: https://github.com/apache/arrow/pull/35810#discussion_r1255175664
##########
csharp/src/Apache.Arrow/C/CArrowArrayStream.cs:
##########
@@ -35,15 +35,23 @@ public unsafe struct CArrowArrayStream
///
/// Return value: 0 if successful, an `errno`-compatible error code
otherwise.
///</summary>
- public delegate* unmanaged[Stdcall]<CArrowArrayStream*, CArrowSchema*,
int> get_schema;
Review Comment:
Another option would be to only publicly expose the function pointer fields
on `net5.0+`. Keep them `internal` for netstandard and netfx where they need to
be declared `Cdecl` (and honestly function pointers aren't really meant to be
used on netfx and netstandard since they came in C# 9 -
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version).
That way users on net5+ can still call the function pointers, if they need
to. For netstandard and netfx, they are no worse off - they can't call them
with this change anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
