WillAyd commented on PR #879:
URL: https://github.com/apache/arrow-adbc/pull/879#issuecomment-1624676473
Ah OK. So the issue is that the TearDown is only called once for
`StatementTest::TestSqlIngestTimestamp`, but that implementation is currently:
```cpp
ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_SECOND>());
ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MICRO>());
ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MILLI>());
ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_NANO>());
```
Every `TestSqlIngestTemporalType` invocation instatiates a new statement,
hence the leak
Might be overlooking something but it seems a bit strange that the
`AdbcStatementNew` call is in `TestSqlIngestType` but `TearDownTest` has the
release; I think either the lifecycle already here is better, or maybe we
should add `AdbcStatementNew` to the SetUp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
