mustafasrepo commented on code in PR #6869: URL: https://github.com/apache/arrow-datafusion/pull/6869#discussion_r1255330814
########## datafusion/expr/src/partition_evaluator.rs: ########## @@ -87,16 +87,23 @@ use crate::window_state::WindowAggState; /// previous batch. The previous row number is saved and restored as /// the state. /// -/// When implementing a new `PartitionEvaluator`, -/// `uses_window_frame` and `supports_bounded_execution` flags determine which evaluation method will be called -/// during runtime. Implement corresponding evaluator according to table below. +/// When implementing a new `PartitionEvaluator`, implement +/// corresponding evaluator according to table below. /// -/// |uses_window_frame|supports_bounded_execution|function_to_implement| -/// |---|---|----| -/// |false|false|`evaluate_all` (if we were to implement `PERCENT_RANK` it would end up in this quadrant, we cannot produce any result without seeing whole data)| -/// |false|true|`evaluate` (optionally can also implement `evaluate_all` for more optimized implementation. However, there will be default implementation that is suboptimal) . If we were to implement `ROW_NUMBER` it will end up in this quadrant. Example `OddRowNumber` showcases this use case| -/// |true|false|`evaluate` (I think as long as `uses_window_frame` is `true`. There is no way for `supports_bounded_execution` to be false). I couldn't come up with any example for this quadrant | -/// |true|true|`evaluate`. If we were to implement `FIRST_VALUE`, it would end up in this quadrant|. +/// +/// |[`uses_window_frame`]|[`supports_bounded_execution`]|[`include_rank`]|function_to_implement| +/// |---|---|----|----| +/// |false (default) |false (default) |false (default) | [`evaluate_all`] | +/// |false |true |false | [`evaluate`] | +/// |false |true/false |true | [`evaluate_all_with_rank`] | +/// |true |true/false |true/false | [`evaluate`] | Review Comment: :heart: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
