andygrove commented on pull request #8961:
URL: https://github.com/apache/arrow/pull/8961#issuecomment-748639459
@Dandandan This needs rebasing - I tried merging into master locally before
merging this and got some compilation errors.
```
error[E0050]: method `scan` has 3 parameters but the declaration in trait
`datasource::datasource::TableProvider::scan` has 4
--> datafusion/src/optimizer/hash_build_probe_order.rs:179:13
|
179 | / &self,
180 | | _projection: &Option<Vec<usize>>,
181 | | _batch_size: usize,
| |______________________________^ expected 4 parameters, found 3
|
::: datafusion/src/datasource/datasource.rs:66:9
|
66 | / &self,
67 | | projection: &Option<Vec<usize>>,
68 | | batch_size: usize,
69 | | filters: &[Expr],
| |________________________- trait requires 4 parameters
error: cannot construct `plan::LogicalPlan` with struct literal syntax due
to inaccessible fields
--> datafusion/src/optimizer/hash_build_probe_order.rs:204:23
|
204 | let lp_left = LogicalPlan::TableScan {
| ^^^^^^^^^^^^^^^^^^^^^^
error: cannot construct `plan::LogicalPlan` with struct literal syntax due
to inaccessible fields
--> datafusion/src/optimizer/hash_build_probe_order.rs:211:24
|
211 | let lp_right = LogicalPlan::TableScan {
| ^^^^^^^^^^^^^^^^^^^^^^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
