jorisvandenbossche commented on code in PR #36462:
URL: https://github.com/apache/arrow/pull/36462#discussion_r1255770474
##########
python/pyarrow/includes/libarrow_dataset.pxd:
##########
@@ -288,13 +288,14 @@ cdef extern from "arrow/dataset/api.h" namespace
"arrow::dataset" nogil:
c_string type_name() const
CResult[CExpression] Parse(const c_string & path) const
const shared_ptr[CSchema] & schema()
+ c_bool Equals(const CPartitioning& other) const
cdef cppclass CSegmentEncoding" arrow::dataset::SegmentEncoding":
- pass
+ bint operator==(CSegmentEncoding)
Review Comment:
`c_bool` comes from `from libcpp cimport bool as c_bool`, while `bint` is a
built-in cython type (for C boolean values, i.e. int with 0/non-0 values for
False/True). Not fully sure in which case which should be used (or if it
matters). I think generally where we expect to pass a Python boolean (eg in
signatures) we use `bint`, while `c_bool` is mostly used when interfacing with
the C++ declared methods.
In this case I copied it from another place in the pxd file that was using
the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
