rok commented on code in PR #36496:
URL: https://github.com/apache/arrow/pull/36496#discussion_r1255869376
##########
cpp/src/arrow/extension/fixed_shape_tensor.h:
##########
@@ -62,6 +62,11 @@ class ARROW_EXPORT FixedShapeTensorType : public
ExtensionType {
std::string extension_name() const override { return
"arrow.fixed_shape_tensor"; }
+ std::string ToString() const override {
+ return "extension<" + this->extension_name() + "<type: " +
value_type_->ToString() +
+ ", " + this->Serialize() + ">>";
Review Comment:
Agreed on the readability and briefness.
Of the proposed formats first feels most readable to me. Maybe switch
`type`->`value_type`:
`fixed_shape_tensor[value_type=int32, shape=[2,2,3], permutation=[0,2,1]]`
to be consistent with the
[API](https://github.com/apache/arrow/blob/main/cpp/src/arrow/extension/fixed_shape_tensor.h#L72)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
