westonpace commented on issue #36523: URL: https://github.com/apache/arrow/issues/36523#issuecomment-1625618307
> By the way, it seems S3 is disabled in our TSAN CI job. Should we enable it? It would be nice. We do a fair amount of thread management here. However, it's mostly controlled by `Future` / `AsyncTaskScheduler` / etc. so perhaps not as critical. Note that I did not actually end up finding any real bugs with TSAN once I quieted down the false positives. > A reasonable fix is to lock the client holder only as long as necessary. I should have done that from the start: That seems fine. I think it would still be good to unlock the upload_state before marking the flush complete too. It's not a bug but it will make it easier to reason about the code in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
