viirya commented on code in PR #6874:
URL: https://github.com/apache/arrow-datafusion/pull/6874#discussion_r1256054535
##########
datafusion/core/src/physical_plan/sorts/merge.rs:
##########
@@ -52,7 +52,7 @@ macro_rules! merge_helper {
}
/// Perform a streaming merge of [`SendableRecordBatchStream`]
-pub(crate) fn streaming_merge(
+pub fn streaming_merge(
Review Comment:
For a public API, I suggest that we can provide more clear doc for it. E.g.,
this will sort stream based on provided expressions etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]