wgtmac commented on PR #14341: URL: https://github.com/apache/arrow/pull/14341#issuecomment-1625666937
There seems to be obvious issues from the ASAN report (https://github.com/apache/arrow/actions/runs/5481124113/jobs/9985061685?pr=14341 ). Could you fix them first? ``` FAILED: src/parquet/CMakeFiles/parquet-internals-test.dir/encoding_test.cc.o /arrow/cpp/src/parquet/encoding_test.cc:1954:35: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32] num_values_ = array->length() - array->null_count(); ~ ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ /arrow/cpp/src/parquet/encoding_test.cc:1959:5: note: in instantiation of member function 'parquet::test::TestDeltaByteArrayEncoding<parquet::PhysicalType<parquet::Type::FIXED_LEN_BYTE_ARRAY>>::InitData' requested here InitData(nvalues, null_probability); ^ /arrow/cpp/src/parquet/encoding_test.cc:2022:33: note: in instantiation of member function 'parquet::test::TestDeltaByteArrayEncoding<parquet::PhysicalType<parquet::Type::FIXED_LEN_BYTE_ARRAY>>::Execute' requested here ASSERT_NO_FATAL_FAILURE(this->Execute(0, 0)); ^ /build/cpp/googletest_ep-prefix/include/gtest/internal/gtest-internal.h:472:44: note: in instantiation of member function 'parquet::test::TestDeltaByteArrayEncoding_BasicRoundTrip_Test<parquet::PhysicalType<parquet::Type::FIXED_LEN_BYTE_ARRAY>>::TestBody' requested here Test* CreateTest() override { return new TestClass; } ^ /build/cpp/googletest_ep-prefix/include/gtest/internal/gtest-internal.h:740:13: note: in instantiation of member function 'testing::internal::TestFactoryImpl<parquet::test::TestDeltaByteArrayEncoding_BasicRoundTrip_Test<parquet::PhysicalType<parquet::Type::FIXED_LEN_BYTE_ARRAY>>>::CreateTest' requested here new TestFactoryImpl<TestClass>); ^ /build/cpp/googletest_ep-prefix/include/gtest/internal/gtest-internal.h:744:57: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<parquet::test::TestDeltaByteArrayEncoding, testing::internal::TemplateSel<parquet::test::TestDeltaByteArrayEncoding_BasicRoundTrip_Test>, testing::internal::Types<parquet::PhysicalType<parquet::Type::FIXED_LEN_BYTE_ARRAY>>>::Register' requested here typename Types::Tail>::Register(prefix, ^ /arrow/cpp/src/parquet/encoding_test.cc:2021:1: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<parquet::test::TestDeltaByteArrayEncoding, testing::internal::TemplateSel<parquet::test::TestDeltaByteArrayEncoding_BasicRoundTrip_Test>, testing::internal::Types<parquet::PhysicalType<parquet::Type::BYTE_ARRAY>, parquet::PhysicalType<parquet::Type::FIXED_LEN_BYTE_ARRAY>>>::Register' requested here TYPED_TEST(TestDeltaByteArrayEncoding, BasicRoundTrip) { ^ /build/cpp/googletest_ep-prefix/include/gtest/gtest-typed-test.h:212:27: note: expanded from macro 'TYPED_TEST' CaseName)>::Register("", \ ^ /arrow/cpp/src/parquet/encoding_test.cc:1954:35: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32] num_values_ = array->length() - array->null_count(); ~ ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ /arrow/cpp/src/parquet/encoding_test.cc:1959:5: note: in instantiation of member function 'parquet::test::TestDeltaByteArrayEncoding<parquet::PhysicalType<parquet::Type::BYTE_ARRAY>>::InitData' requested here InitData(nvalues, null_probability); ^ /arrow/cpp/src/parquet/encoding_test.cc:2022:33: note: in instantiation of member function 'parquet::test::TestDeltaByteArrayEncoding<parquet::PhysicalType<parquet::Type::BYTE_ARRAY>>::Execute' requested here ASSERT_NO_FATAL_FAILURE(this->Execute(0, 0)); ^ /build/cpp/googletest_ep-prefix/include/gtest/internal/gtest-internal.h:472:44: note: in instantiation of member function 'parquet::test::TestDeltaByteArrayEncoding_BasicRoundTrip_Test<parquet::PhysicalType<parquet::Type::BYTE_ARRAY>>::TestBody' requested here Test* CreateTest() override { return new TestClass; } ^ /build/cpp/googletest_ep-prefix/include/gtest/internal/gtest-internal.h:740:13: note: in instantiation of member function 'testing::internal::TestFactoryImpl<parquet::test::TestDeltaByteArrayEncoding_BasicRoundTrip_Test<parquet::PhysicalType<parquet::Type::BYTE_ARRAY>>>::CreateTest' requested here new TestFactoryImpl<TestClass>); ^ /arrow/cpp/src/parquet/encoding_test.cc:2021:1: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<parquet::test::TestDeltaByteArrayEncoding, testing::internal::TemplateSel<parquet::test::TestDeltaByteArrayEncoding_BasicRoundTrip_Test>, testing::internal::Types<parquet::PhysicalType<parquet::Type::BYTE_ARRAY>, parquet::PhysicalType<parquet::Type::FIXED_LEN_BYTE_ARRAY>>>::Register' requested here TYPED_TEST(TestDeltaByteArrayEncoding, BasicRoundTrip) { ^ /build/cpp/googletest_ep-prefix/include/gtest/gtest-typed-test.h:212:27: note: expanded from macro 'TYPED_TEST' CaseName)>::Register("", \ ^ 2 errors generated. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
