tustvold commented on code in PR #4484:
URL: https://github.com/apache/arrow-rs/pull/4484#discussion_r1257281899
##########
arrow-cast/src/cast.rs:
##########
@@ -3680,6 +3680,58 @@ fn cast_primitive_to_list<OffsetSize: OffsetSizeTrait +
NumCast>(
Ok(list_array)
}
+fn build_list_array_with_data_type<OffsetSize: OffsetSizeTrait>(
Review Comment:
Could we perhaps use
https://docs.rs/arrow-buffer/latest/arrow_buffer/buffer/struct.OffsetBuffer.html#method.from_lengths
and
https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericListArray.html#method.new
instead of the unsafe ArrayDate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
