jp0317 commented on code in PR #36510:
URL: https://github.com/apache/arrow/pull/36510#discussion_r1257354094
##########
cpp/src/parquet/file_reader.h:
##########
@@ -44,7 +44,8 @@ class PARQUET_EXPORT RowGroupReader {
// An implementation of the Contents class is defined in the .cc file
struct Contents {
virtual ~Contents() {}
- virtual std::unique_ptr<PageReader> GetColumnPageReader(int i) = 0;
+ virtual std::unique_ptr<PageReader> GetColumnPageReader(int i,
Review Comment:
Yes, it's intended. And i think the caller behavior is almost the same: the
only difference is that they now have one more option to customize the buffer
size per column chunk, in addition to setting the [read
properties](https://github.com/apache/arrow/blob/main/cpp/src/parquet/properties.h#L121)
shared by all chunks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
