assignUser commented on code in PR #36584:
URL: https://github.com/apache/arrow/pull/36584#discussion_r1257683765
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -36,7 +36,7 @@ if(GRPCPP_PC_FOUND)
# gRPC's pkg-config file neglects to specify pthreads.
find_package(Threads REQUIRED)
if(ARROW_GRPC_USE_SHARED)
- set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES} Threads::Threads)
+ list(APPEND GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})
Review Comment:
It will create the list if it does not exists but I see how using set is
more expressive (also less chars :D).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
