kou commented on code in PR #36595:
URL: https://github.com/apache/arrow/pull/36595#discussion_r1258401099
##########
.github/workflows/cpp.yml:
##########
@@ -219,18 +219,16 @@ jobs:
ci/scripts/cpp_test.sh $(pwd) $(pwd)/build
windows:
- name: AMD64 ${{ matrix.name }} C++17
- runs-on: ${{ matrix.os }}
+ name: AMD64 Windows ${{ matrix.version }} C++17
+ runs-on: windows-${{ matrix.version }}
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
timeout-minutes: 60
strategy:
fail-fast: false
matrix:
- os:
- - windows-2019
- include:
- - os: windows-2019
- name: Windows 2019
+ version:
+ - 2019
+ - 2022
Review Comment:
OK.
I'll add `verify-rc-source-windows-2022` and remove this after we confirm
that this changes work with MSVC 2022 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
