lidavidm commented on code in PR #700:
URL: https://github.com/apache/arrow-adbc/pull/700#discussion_r1258418071
##########
go/adbc/adbc.go:
##########
@@ -58,13 +58,15 @@ type Error struct {
// SqlState is a SQLSTATE error code, if provided, as defined
// by the SQL:2003 standard. If not set, it will be "\0\0\0\0\0"
SqlState [5]byte
- // Details is an array of additional driver-specific binary error
details.
+ // Details is an array of additional driver-specific error details.
//
// This allows drivers to return custom, structured error information
(for
// example, JSON or Protocol Buffers) that can be optionally parsed by
// clients, beyond the standard Error fields, without having to encode
it in
- // the error message. The encoding of the data is driver-defined.
- Details [][]byte
+ // the error message. The encoding of the data is driver-defined. It
is
+ // suggested to use proto.Message for Protocol Buffers and error for
wrapped
+ // errors.
+ Details []interface{}
Review Comment:
~Mostly so that we could keep strong typing for things like Protobufs,
otherwise we would be forced to serialize them here. I'm sort of ambivalent
here.
While working on Java, I also made this an array of key-value pairs; I plan
to port that change here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
