alamb commented on code in PR #6904: URL: https://github.com/apache/arrow-datafusion/pull/6904#discussion_r1258632894
########## datafusion/core/src/physical_plan/aggregates/row_hash.rs: ########## @@ -16,100 +16,181 @@ // under the License. //! Hash aggregation through row format +//! Review Comment: This diff is going to be hard to read -- I recommend anyone interested look at the code directly here: https://github.com/alamb/arrow-datafusion/blob/alamb/fast_gby_hash/datafusion/core/src/physical_plan/aggregates/row_hash.rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
