vincev commented on PR #6903: URL: https://github.com/apache/arrow-datafusion/pull/6903#issuecomment-1630908137
> This code looks really nice @vincev -- one concern I have is that it seems to no longer handle StringArray (which is not a `PrimitiveArray`. However, since all the CI tests pass that either means I don't fully understand how this code works or we have a gap in testing. Thank you @alamb , just doubled checked the tests [here](https://github.com/vincev/arrow-datafusion/blob/9f3ae22c9043476e7ff2c0026f8fcf2dd5004072/datafusion/core/tests/dataframe/mod.rs#L944), we cover for `StringArray`. As far I can see the `PrimitiveArray` is only used for the list lengths and the indices that are used by the `take` kernel, I'll improve the comments on how it works after your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
