mustafasrepo commented on code in PR #6904:
URL: https://github.com/apache/arrow-datafusion/pull/6904#discussion_r1259801913
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -211,28 +256,38 @@ impl GroupedHashAggregateStream {
schema: agg_schema,
input,
mode: agg.mode,
- normal_aggr_expr,
- normal_aggregate_expressions,
- normal_filter_expressions,
- row_aggregate_expressions,
- row_filter_expressions,
- row_accumulators,
+ accumulators,
+ aggregate_arguments,
+ filter_expressions,
row_converter,
- row_aggr_schema,
- row_aggr_layout,
group_by: agg_group_by,
- aggr_state,
+ reservation,
+ map,
+ group_values,
+ scratch_space: ScratchSpace::new(),
exec_state,
baseline_metrics,
random_state: Default::default(),
batch_size,
- scalar_update_factor,
- row_group_skip_position: 0,
- indices: [normal_agg_indices, row_agg_indices],
})
}
}
+/// Create an accumulator for `agg_expr` -- a [`GroupsAccumulator`] if
+/// that is supported by the aggrgate, or a
Review Comment:
```suggestion
/// that is supported by the aggregate, or a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
