felipecrv commented on code in PR #36489:
URL: https://github.com/apache/arrow/pull/36489#discussion_r1260224994
##########
cpp/src/arrow/c/bridge.cc:
##########
@@ -663,6 +672,112 @@ Status ExportRecordBatch(const RecordBatch& batch, struct
ArrowArray* out,
return Status::OK();
}
+//////////////////////////////////////////////////////////////////////////
+// C device arrays
+
+Status ValidateDeviceInfo(const ArrayData& data, DeviceType* device_type,
+ int64_t* device_id) {
+ for (const auto& buf : data.buffers) {
+ if (!buf) {
+ continue;
+ }
+
+ if (*device_type == DeviceType::UNKNOWN) {
Review Comment:
But that is fine I think. The constraint imposed here is that non-UNKNOWN
buffers SHOULD NOT be distinct. So only one different from UNKNOWN is trivial.
UPDATE: rewrote comment as there was a mistake in what I wanted to say and
what I wrote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
