nealrichardson commented on PR #36551:
URL: https://github.com/apache/arrow/pull/36551#issuecomment-1631812868

   > > How does upstream autobrew handle this?
   > 
   > I am not sure what this means! I assumed the formula in the autobrew repos 
is modified to reflect the one I modified here before each release? My 
understanding of autobrew is admittedly limited.
   
   We do, but @jeroen maintains the actual autobrew formulae and scripts 
([here](https://github.com/autobrew/homebrew-cran/blob/master/Formula/apache-arrow-static.rb),
 
[here](https://github.com/autobrew/homebrew-core/blob/high-sierra/Formula/apache-arrow.rb),
 and [here](https://github.com/autobrew/scripts/blob/master/apache-arrow), 
specifically), of which ours are copies that we modify to test on every commit. 
When changes to Homebrew happen or CRAN mandates new things, he handles it 
there, and we should watch (at release time, or when things break) for changes 
we need to pull in accordingly to stay in sync. 
   
   I don't see openssl pinned there, so I'm not sure what's different such that 
we need it--something with the self-hosted runner setup, perhaps? If so, that's 
probably ok, though might be worth adding comments that that's the case.
   
   Re: openssl version, Homebrew actually has `openssl@3`: 
https://github.com/Homebrew/homebrew-core/blob/master/Formula/apache-arrow.rb#L30
 If our copy is pinned on 1.1, we should update it, and pull in any other 
changes from upstream, same as autobrew.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to