lidavidm commented on code in PR #893:
URL: https://github.com/apache/arrow-adbc/pull/893#discussion_r1261568177
##########
go/adbc/pkg/_tmpl/driver.go.tmpl:
##########
@@ -71,7 +73,7 @@ func setErr(err *C.struct_AdbcError, format string, vals
...interface{}) {
}
func errToAdbcErr(adbcerr *C.struct_AdbcError, err error) adbc.Status {
- if adbcerr == nil || err == nil {
Review Comment:
It's checked in setErr, and the code originally was a bug, because if you
didn't pass in an AdbcError you'd always get OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
