sgilmore10 commented on code in PR #36653: URL: https://github.com/apache/arrow/pull/36653#discussion_r1261714573
########## matlab/src/matlab/+arrow/+type/+traits/Int16Traits.m: ########## @@ -0,0 +1,29 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef Int16Traits < arrow.type.traits.Traits + + properties (Constant) + ArrayConstructor = @arrow.array.Int16Array + ArrayClassName = "arrow.array.Int16Array" + ArrayProxyClassName = "arrow.array.proxy.Int16Array" + TypeConstructor = @arrow.type.Int16Type; + TypeClassName = "arrow.type.Int16Type" + TypeProxyClassName = "arrow.type.proxy.Int16Type" + MatlabConstructor = @uint16 Review Comment: This should be `@int16` instead of `@uint16` ########## matlab/src/matlab/+arrow/+type/+traits/Int16Traits.m: ########## @@ -0,0 +1,29 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef Int16Traits < arrow.type.traits.Traits + + properties (Constant) + ArrayConstructor = @arrow.array.Int16Array + ArrayClassName = "arrow.array.Int16Array" + ArrayProxyClassName = "arrow.array.proxy.Int16Array" + TypeConstructor = @arrow.type.Int16Type; + TypeClassName = "arrow.type.Int16Type" + TypeProxyClassName = "arrow.type.proxy.Int16Type" + MatlabConstructor = @uint16 + MatlabClassName = "uint16" Review Comment: `uint16` -> `int16` ########## matlab/test/arrow/type/traits/tInt64Traits.m: ########## @@ -0,0 +1,30 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef tInt64Traits < hTraits + + properties + TraitsConstructor = @arrow.type.traits.Int64Traits + ArrayConstructor = @arrow.array.Int64Array + ArrayClassName = "arrow.array.Int64Array" + ArrayProxyClassName = "arrow.array.proxy.Int64Array" + TypeConstructor = @arrow.type.Int64Type + TypeClassName = "arrow.type.Int64Type" + TypeProxyClassName = "arrow.type.proxy.Int64Type" + MatlabConstructor = @uint64 Review Comment: `@uint64` -> `@int64` `uint64` -> `int64` ########## matlab/src/matlab/+arrow/+type/+traits/Int32Traits.m: ########## @@ -0,0 +1,29 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef Int32Traits < arrow.type.traits.Traits + + properties (Constant) + ArrayConstructor = @arrow.array.Int32Array + ArrayClassName = "arrow.array.Int32Array" + ArrayProxyClassName = "arrow.array.proxy.Int32Array" + TypeConstructor = @arrow.type.Int32Type; + TypeClassName = "arrow.type.Int32Type" + TypeProxyClassName = "arrow.type.proxy.Int32Type" + MatlabConstructor = @uint32 Review Comment: `@uint32` -> `@int32` ########## matlab/src/matlab/+arrow/+type/+traits/Int64Traits.m: ########## @@ -0,0 +1,29 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef Int64Traits < arrow.type.traits.Traits + + properties (Constant) + ArrayConstructor = @arrow.array.Int64Array + ArrayClassName = "arrow.array.Int64Array" + ArrayProxyClassName = "arrow.array.proxy.Int64Array" + TypeConstructor = @arrow.type.Int64Type; + TypeClassName = "arrow.type.Int64Type" + TypeProxyClassName = "arrow.type.proxy.Int64Type" + MatlabConstructor = @uint64 Review Comment: `@uint64` -> `@int64` ########## matlab/src/matlab/+arrow/+type/+traits/Int32Traits.m: ########## @@ -0,0 +1,29 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef Int32Traits < arrow.type.traits.Traits + + properties (Constant) + ArrayConstructor = @arrow.array.Int32Array + ArrayClassName = "arrow.array.Int32Array" + ArrayProxyClassName = "arrow.array.proxy.Int32Array" + TypeConstructor = @arrow.type.Int32Type; + TypeClassName = "arrow.type.Int32Type" + TypeProxyClassName = "arrow.type.proxy.Int32Type" + MatlabConstructor = @uint32 + MatlabClassName = "uint32" Review Comment: `uint32` -> `int32` ########## matlab/test/arrow/type/traits/tInt32Traits.m: ########## @@ -0,0 +1,30 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef tInt32Traits < hTraits + + properties + TraitsConstructor = @arrow.type.traits.Int32Traits + ArrayConstructor = @arrow.array.Int32Array + ArrayClassName = "arrow.array.Int32Array" + ArrayProxyClassName = "arrow.array.proxy.Int32Array" + TypeConstructor = @arrow.type.Int32Type + TypeClassName = "arrow.type.Int32Type" + TypeProxyClassName = "arrow.type.proxy.Int32Type" + MatlabConstructor = @uint32 Review Comment: `@uint32` -> `@int32` `uint32` -> `int32` ########## matlab/test/arrow/type/traits/tInt16Traits.m: ########## @@ -0,0 +1,30 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef tInt16Traits < hTraits + + properties + TraitsConstructor = @arrow.type.traits.Int16Traits + ArrayConstructor = @arrow.array.Int16Array + ArrayClassName = "arrow.array.Int16Array" + ArrayProxyClassName = "arrow.array.proxy.Int16Array" + TypeConstructor = @arrow.type.Int16Type + TypeClassName = "arrow.type.Int16Type" + TypeProxyClassName = "arrow.type.proxy.Int16Type" + MatlabConstructor = @uint16 Review Comment: `@uint16` -> `@int16` `uint16` -> `int16` ########## matlab/src/matlab/+arrow/+type/+traits/Int64Traits.m: ########## @@ -0,0 +1,29 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef Int64Traits < arrow.type.traits.Traits + + properties (Constant) + ArrayConstructor = @arrow.array.Int64Array + ArrayClassName = "arrow.array.Int64Array" + ArrayProxyClassName = "arrow.array.proxy.Int64Array" + TypeConstructor = @arrow.type.Int64Type; + TypeClassName = "arrow.type.Int64Type" + TypeProxyClassName = "arrow.type.proxy.Int64Type" + MatlabConstructor = @uint64 + MatlabClassName = "uint64" Review Comment: `uint64` -> `int64` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
