alamb commented on code in PR #4511:
URL: https://github.com/apache/arrow-rs/pull/4511#discussion_r1261733616
##########
arrow-cast/src/cast.rs:
##########
@@ -5098,7 +5070,7 @@ mod tests {
)
.unwrap();
assert_eq!(5, b.len());
- assert_eq!(1, b.null_count());
+ assert_eq!(0, b.null_count());
Review Comment:
Is the difference that b[1] is [null] (aka a 1 element list with a null)
rather than null itself? I believe that is already covered below.
##########
arrow-cast/src/cast.rs:
##########
@@ -9448,4 +9420,21 @@ mod tests {
assert_eq!("1969-12-31", string_array.value(1));
assert_eq!("1989-12-31", string_array.value(2));
}
+
+ #[test]
+ fn test_nested_list() {
+ let mut list = ListBuilder::new(Int32Builder::new());
+ list.append_value([Some(1), Some(2), Some(3)]);
+ list.append_value([Some(4), Some(5), Some(6)]);
Review Comment:
Can we please include a NULL in the list -- for example,
```suggestion
list.append_value([Some(4), Null, Some(6)]);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
