rok commented on code in PR #14341:
URL: https://github.com/apache/arrow/pull/14341#discussion_r1261894605
##########
cpp/src/parquet/encoding_test.cc:
##########
@@ -874,7 +874,7 @@ std::shared_ptr<::arrow::Array>
EncodingAdHocTyped<FLBAType>::GetValues(int seed
}
using EncodingAdHocTypedCases =
- ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType,
FLBAType>;
+ ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType>;
Review Comment:
`FLBAType` was removed due to changes to `EncodingTraits<FLBAType>` above.
Perhaps we could do something like:
```
if constexpr (IsFixedSizeBinary::value) {
using BuilderType = typename EncodingTraits<ParquetType>::BuilderType;
} else {
using BuilderType = typename EncodingTraits<ParquetType>::Accumulator;
}
```
to get arround this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
