wgtmac commented on code in PR #36654:
URL: https://github.com/apache/arrow/pull/36654#discussion_r1262237279
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -301,12 +318,8 @@ namespace {
Status ValidateBatch(const RecordBatch& batch, bool full_validation) {
for (int i = 0; i < batch.num_columns(); ++i) {
+ RETURN_NOT_OK(ValidateColumnLength(batch, i));
Review Comment:
nit: passing `array` created in line 304 to `ValidateColumnLength` to avoid
creating shared_ptr twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
