mustafasrepo commented on PR #6950: URL: https://github.com/apache/arrow-datafusion/pull/6950#issuecomment-1634257252
According to `CombinePartialFinalAggregate` rule, when planner sees `AggregateMode::Partial` + `AggregateMode::Final` or `AggregateMode::Partial` + `AggregateMode::FinalPartitioned`, it replaces these immediate operators with `AggregateMode::Single`. For second case changing distribution requirement to `Distribution::HashPartitioned` makes sense. However, for first case distribution requirement should be `SinglePartition` I guess. With the proposed changes, `AggregateMode::Single` will require `vec![Distribution::HashPartitioned(vec![])]` (where group by is empty). when it is constructed from `AggregateMode::Partial` + `AggregateMode::Final` stack. Will this requirement add `RepartitionExec(hash)` during planning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
