viirya commented on code in PR #6957:
URL: https://github.com/apache/arrow-datafusion/pull/6957#discussion_r1262797697
##########
datafusion/physical-expr/src/aggregate/bit_and_or_xor.rs:
##########
@@ -279,35 +280,31 @@ impl AggregateExpr for BitAnd {
use std::ops::BitAndAssign;
match self.data_type {
DataType::Int8 => {
- instantiate_primitive_accumulator!(self, Int8Type, |x, y| x
- .bitand_assign(y))
+ instantiate_accumulator!(self, -1, Int8Type, |x, y|
x.bitand_assign(y))
Review Comment:
The fix looks good. It's better to leave a comment like above in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
