lidavidm commented on code in PR #36675:
URL: https://github.com/apache/arrow/pull/36675#discussion_r1263031617
##########
cpp/src/parquet/arrow/reader.h:
##########
@@ -145,22 +145,6 @@ class PARQUET_EXPORT FileReader {
virtual ::arrow::Status ReadColumn(int i,
std::shared_ptr<::arrow::ChunkedArray>*
out) = 0;
- // NOTE: Experimental API
- // Reads a specific top level schema field into an Array
- // The index i refers the index of the top level schema field, which may
- // be nested or flat - e.g.
- //
- // 0 foo.bar
- // foo.bar.baz
- // foo.qux
- // 1 foo2
- // 2 foo3
- //
- // i=0 will read the entire foo struct, i=1 the foo2 primitive column etc
Review Comment:
The docstring might be good to keep as part of ReadColumn? Or does it mean
something different?
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -499,27 +499,27 @@ TEST_F(TestRecordBatchReader, ToTable) {
ARROW_SUPPRESS_DEPRECATION_WARNING
TEST_F(TestRecordBatchReader, DeprecatedReadAllToRecordBatches) {
Review Comment:
Sounds like the entire test may not be needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
