kou commented on code in PR #36662:
URL: https://github.com/apache/arrow/pull/36662#discussion_r1263158263
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -62,29 +62,32 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
"${ARROW_AVX512_FLAG} -mavx512f -mavx512cd -mavx512vl -mavx512dq
-mavx512bw")
check_cxx_compiler_flag(${ARROW_SSE4_2_FLAG} CXX_SUPPORTS_SSE4_2)
endif()
- check_cxx_compiler_flag(${ARROW_AVX2_FLAG} CXX_SUPPORTS_AVX2)
- if(MINGW)
- # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65782
- message(STATUS "Disable AVX512 support on MINGW for now")
- else()
- # Check for AVX512 support in the compiler.
- set(OLD_CMAKE_REQURED_FLAGS ${CMAKE_REQUIRED_FLAGS})
- set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${ARROW_AVX512_FLAG}")
- check_cxx_source_compiles("
- #ifdef _MSC_VER
- #include <intrin.h>
- #else
- #include <immintrin.h>
- #endif
-
- int main() {
- __m512i mask = _mm512_set1_epi32(0x1);
- char out[32];
- _mm512_storeu_si512(out, mask);
- return 0;
- }"
- CXX_SUPPORTS_AVX512)
- set(CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQURED_FLAGS})
+ if(CMAKE_SIZEOF_VOID_P EQUAL 8)
Review Comment:
Yes. We need to use the pointer size to detect whether 64-bit environment or
not on CMake.
##########
docker-compose.yml:
##########
@@ -72,6 +72,10 @@ x-sccache: &sccache
SCCACHE_REGION:
SCCACHE_S3_KEY_PREFIX: ${SCCACHE_S3_KEY_PREFIX:-sccache}
+x-cpp: &cpp
+ ARROW_RUNTIME_SIMD_LEVEL:
+ ARROW_SIMD_LEVEL:
+
Review Comment:
I don't object `cpp` but I like `simd`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
