indigophox commented on code in PR #34817: URL: https://github.com/apache/arrow/pull/34817#discussion_r1263272700
########## cpp/src/arrow/flight/sql/client.cc: ########## @@ -31,6 +31,7 @@ #include "arrow/result.h" #include "arrow/util/logging.h" +namespace pb = arrow::flight::protocol; Review Comment: Considered doing this as `flight_pb` however this is more consistent with usage elsewhere and could eliminate uses of `flight_sql_pb` for better uniformity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
