alamb commented on PR #6954: URL: https://github.com/apache/arrow-datafusion/pull/6954#issuecomment-1635709082
Special casing the nulls seems to have helped a little, though the fact that some queries now report slower is surprising to me ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ alamb_faster_grouping ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 574.53ms │ 522.95ms │ +1.10x faster │ │ QQuery 2 │ 168.33ms │ 152.40ms │ +1.10x faster │ │ QQuery 3 │ 173.45ms │ 182.54ms │ 1.05x slower │ │ QQuery 4 │ 116.60ms │ 116.16ms │ no change │ │ QQuery 5 │ 402.46ms │ 405.81ms │ no change │ │ QQuery 6 │ 45.04ms │ 41.94ms │ +1.07x faster │ │ QQuery 7 │ 922.93ms │ 916.25ms │ no change │ │ QQuery 8 │ 255.73ms │ 240.93ms │ +1.06x faster │ │ QQuery 9 │ 577.15ms │ 554.53ms │ no change │ │ QQuery 10 │ 318.40ms │ 330.10ms │ no change │ │ QQuery 11 │ 167.56ms │ 172.50ms │ no change │ │ QQuery 12 │ 174.26ms │ 177.85ms │ no change │ │ QQuery 13 │ 324.26ms │ 320.80ms │ no change │ │ QQuery 14 │ 48.11ms │ 48.24ms │ no change │ │ QQuery 15 │ 54.18ms │ 57.05ms │ 1.05x slower │ │ QQuery 16 │ 164.83ms │ 168.32ms │ no change │ │ QQuery 17 │ 897.29ms │ 877.01ms │ no change │ │ QQuery 18 │ 1672.32ms │ 1675.61ms │ no change │ │ QQuery 19 │ 179.13ms │ 166.64ms │ +1.07x faster │ │ QQuery 20 │ 324.28ms │ 324.27ms │ no change │ │ QQuery 21 │ 1147.35ms │ 1177.47ms │ no change │ │ QQuery 22 │ 93.86ms │ 91.11ms │ no change │ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
