tustvold commented on code in PR #4520:
URL: https://github.com/apache/arrow-rs/pull/4520#discussion_r1263738458


##########
arrow-string/src/length.rs:
##########
@@ -88,6 +88,30 @@ where
     unary_offsets!(array, T::DATA_TYPE, |x| x)
 }
 
+fn length_list_fixed_size<T>(array: &dyn Array, length: i32) -> ArrayRef
+where
+    T: ArrowPrimitiveType,
+    T::Native: OffsetSizeTrait,
+{
+    let array = array.as_any().downcast_ref::<FixedSizeListArray>().unwrap();
+    let null_bit_buffer = array.nulls().map(|b| b.inner().sliced());
+    let length_list = array.len();
+    let buffer = Buffer::from_vec(vec![length; length_list]);
+
+    let data = unsafe {

Review Comment:
   Perhaps we could use PrimitiveArray::new here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to