mustafasrepo commented on code in PR #6966: URL: https://github.com/apache/arrow-datafusion/pull/6966#discussion_r1263766403
########## datafusion/expr/src/partition_evaluator.rs: ########## @@ -69,27 +69,10 @@ use crate::window_state::WindowAggState; /// capabilities described by [`supports_bounded_execution`], /// [`uses_window_frame`], and [`include_rank`], /// -/// # Stateless `PartitionEvaluator`s -/// -/// In this case, `PartitionEvaluator` holds no state, and either -/// [`evaluate_all`] or [`evaluate_all_with_rank`] is called with -/// values for the entire partition. -/// -/// # Stateful `PartitionEvaluator`s -/// -/// In this case, [`Self::evaluate`] is called to calculate the window -/// function incrementally for each new batch. -/// -/// For example, when computing `ROW_NUMBER` incrementally, -/// [`Self::evaluate`] will be called multiple times with -/// different batches. For all batches after the first, the output -/// `row_number` must start from last `row_number` produced for the -/// previous batch. The previous row number is saved and restored as -/// the state. -/// Review Comment: I have removed, document related to the stateless and stateful `PartitionEvaluator`s, since it no longer necessary with the removal of `update_state` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
