felipecrv commented on PR #36695: URL: https://github.com/apache/arrow/pull/36695#issuecomment-1636184300
@Sarvesh788 you've accidentally pushed a bunch of java source and binary .class files to the PR. You can fix it and push again. Initial code review: `is_arithmetic` is not necessarily widely applicable to be in `type_traits.h`. Keep it private to the .cc implementing the kernel so that we can expand what it covers without breaking any public API (putting it in `type_traits.h` makes it part of the public API we have to honor forever. See if you can define it in terms of other numeric predicates. Here is a graph illustrating all of them.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
