WillAyd commented on code in PR #907:
URL: https://github.com/apache/arrow-adbc/pull/907#discussion_r1264332716
##########
c/validation/adbc_validation.h:
##########
@@ -274,8 +275,8 @@ class StatementTest {
template <typename CType>
void TestSqlIngestNumericType(ArrowType type);
- template <enum ArrowTimeUnit TU>
- void TestSqlIngestTemporalType(const char* timezone);
+ template <enum ArrowType T>
Review Comment:
Originally I tried to provide ArrowType and ArrowTimeUnit as template
parameters, but that kept yielding errors like
```sh
/home/willayd/clones/arrow-adbc/c/validation/adbc_validation.cc:1173:114:
error: macro "ASSERT_NO_FATAL_FAILURE" passed 2 arguments, but takes just 1
1173 |
ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TYPE_DURATION,
NANOARROW_TIME_UNIT_SECOND>(nullptr));
|
^
In file included from
/home/willayd/clones/arrow-adbc/c/validation/adbc_validation.h:26,
from
/home/willayd/clones/arrow-adbc/c/validation/adbc_validation.cc:18:
/usr/local/include/gtest/gtest.h:2216: note: macro "ASSERT_NO_FATAL_FAILURE"
defined here
2216 | #define ASSERT_NO_FATAL_FAILURE(statement) \
```
I'm not sure if that is a bug with gtest or my lack of C++ template
knowledge, but figured changing the template around like this wasn't a huge deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
