berkaysynnada opened a new pull request, #6982:
URL: https://github.com/apache/arrow-datafusion/pull/6982
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Partially closes #5535.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The implementation of `statistics()` in `FilterExec` has been improved in
two ways:
1) It can now handle complex filter predicates. The previous design was only
able to handle expressions with a single column and simple binary expressions
(such as `a<5` or `3>=a`).
2) It could not shrink the input column boundaries, can only find the
selectivity, and calculate new row count and byte size statistics. Now, new
interval boundaries are inserted into column statistics.
This implementation is a step to unify the range/interval analysis
implementations throughout the project. Interval and cp_solver library
introduced by [this PR](https://github.com/apache/arrow-datafusion/pull/5322)
is well-documented, easy to use, and well-structured. It is considered
appropriate to use in the calculations mentioned.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
1) `statistics()` now updates the newly calculated column intervals.
2) No need to implement different `analyze()` functions for all
`PhysicalExpr`'s, since the cp_solver library can handle different kinds of
PhysicalExpr's while assigning intervals.
3) Cardinality calculations are added to the interval library.
4) `AnalysisContext`'s structure is changed. The selectivity value shouldn't
be inside of `ExprBoundaries`, since this statistic is not related with a
column, it is a measure of all rows in a table. Also, holding a field for
target column results will be outdated since we may now calculate statistics
for multiple columns. Keeping this field can be misleading. In the analyze()
function, the results are overwritten to the input parameters because the old
values are not used after the calculations.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, new tests are added to filter.rs.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
