alamb commented on code in PR #6927:
URL: https://github.com/apache/arrow-datafusion/pull/6927#discussion_r1264681066
##########
datafusion/core/src/datasource/physical_plan/csv.rs:
##########
@@ -656,7 +682,14 @@ mod tests {
let mut config = partitioned_csv_config(file_schema, file_groups)?;
config.projection = Some(vec![0, 2, 4]);
- let csv = CsvExec::new(config, true, b',',
file_compression_type.to_owned());
+ let csv = CsvExec::new(
+ config,
+ true,
+ b',',
+ b'"',
+ None,
Review Comment:
I wonder if we can reduce the number of arguments to `CsvExec::new()`
somehow (like maybe pass in the config 🤔 )
##########
datafusion/core/src/datasource/physical_plan/csv.rs:
##########
@@ -656,7 +682,14 @@ mod tests {
let mut config = partitioned_csv_config(file_schema, file_groups)?;
config.projection = Some(vec![0, 2, 4]);
- let csv = CsvExec::new(config, true, b',',
file_compression_type.to_owned());
+ let csv = CsvExec::new(
+ config,
+ true,
+ b',',
+ b'"',
+ None,
Review Comment:
I wonder if we can reduce the number of arguments to `CsvExec::new()`
somehow (like maybe pass in the config 🤔 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
