pitrou commented on code in PR #36489:
URL: https://github.com/apache/arrow/pull/36489#discussion_r1264682314
##########
cpp/src/arrow/device.h:
##########
@@ -29,6 +29,25 @@
namespace arrow {
+/// \brief EXPERIMENTAL: Device type enum which matches up with C Data Device
types
+enum class DeviceType : char {
Review Comment:
Since we have a class `arrow::Device` which doesn't map 1-to-1 to these enum
members, then I think it would be good to use another name indeed.
As for changing the C ABI: well, it wouldn't change the _ABI_, precisely :-)
Also the C Device Data Interface is very new and still experimental... However,
the names would probably get quite long as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
