jp0317 commented on code in PR #36649:
URL: https://github.com/apache/arrow/pull/36649#discussion_r1264724457
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -2415,7 +2415,7 @@ TEST(TestArrowReadWrite,
CoalescedReadsAndNonCoalescedReads) {
// Pre-buffer 3 columns in the 2nd row group.
const std::vector<int> row_groups = {1};
- const std::vector<int> column_indices = {0, 1, 4};
+ const std::vector<int> column_indices = {0, 3};
Review Comment:
The original 0,1,4 actually coalesce all columns, including the holes
(column 2 and 3). Changing it to 0,3 would ensure
column 4 is not prebuffered. Updated the comments. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
