lidavidm commented on code in PR #36517:
URL: https://github.com/apache/arrow/pull/36517#discussion_r1265306538
##########
cpp/src/arrow/flight/client.cc:
##########
@@ -620,6 +621,17 @@ Status FlightClient::GetFlightInfo(const
FlightCallOptions& options,
return GetFlightInfo(options, descriptor).Value(info);
}
+void FlightClient::GetFlightInfo(const FlightCallOptions& options,
+ const FlightDescriptor& descriptor,
+ std::shared_ptr<AsyncListener<FlightInfo>>
listener) {
+ if (auto status = CheckOpen(); !status.ok()) {
+ listener->OnFinish(
+ TransportStatus{TransportStatusCode::kInternal, status.ToString()});
Review Comment:
At this point the original implementation is too much of a mess or we would
have to make a potentially breaking change (we'd have to replace or deprecate
FlightStatusDetail and/or the mapping between Arrow and Flight status codes)
that has to be coordinated across client/server APIs (since the existing
FlightStatusCode is also used to return certain status codes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
