sgilmore10 opened a new pull request, #36738:
URL: https://github.com/apache/arrow/pull/36738
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
We decided to change the template parameter on
`arrow::matlab::proxy::NumericArray` to `ArrowType` from `CType` to avoid
writing duplicate code. If `proxy::NumericArray` is templated on `ArrowType`,
we can use it to implement the proxies for `Date64Array`, `Date32Array`,
`Time32Array`, `Time64Array`, and `TimestampArray`. It would be best to share
as much as possible.
### What changes are included in this PR?
1. Changed the template on `proxy::NumericArray` from `CType` to `ArrowType`
2. Re-implemented the C++ proxy for `TimestampArray` in terms of
`proxy::NumericArray<arrow::TimestampType>`
3. Defined a template specialization for `NumericArray::make` when the
template parameter is `arrow::TimestampType`.
4. Defined a `proxy::Traits` interface templated on `ArrowType`. Each
specialization defines a `TypeProxy` typedef that can be used at compile-time
to get the proxy class associated with an `ArrowType`.
### Are these changes tested?
Existing tests used.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
