zeroshade commented on PR #909: URL: https://github.com/apache/arrow-adbc/pull/909#issuecomment-1638878426
@lidavidm Hm. In theory we probably could upstream more of this than I did. Right now the only thing I upstreamed was making the `[][]*string` accessible in the loader, the `extractTimestamp` function is mostly pulled from snowflake's library directly. Right now the upstream snowflake library has many things for converting *from* Arrow to other types, but doesn't convert *to* arrow. The only drawback to pushing this upstream is that it puts us back into the situation where we run into problems between the Arrow major version in snowflake vs the Arrow major version in ADBC. Right now we get to avoid that issue by having the conversion here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
