jackwener commented on code in PR #7002:
URL: https://github.com/apache/arrow-datafusion/pull/7002#discussion_r1266389213
##########
datafusion/core/src/physical_plan/unnest.rs:
##########
@@ -425,11 +435,16 @@ where
/// ```ignore
/// 1, null, 2, 3, 4, null, 5, 6
/// ```
-fn unnest_array<T>(list_array: &T) -> Result<Arc<dyn Array + 'static>>
+fn unnest_array<T, P>(
+ list_array: &T,
+ list_array_values: &Arc<dyn Array>,
+ list_lengths: &PrimitiveArray<P>,
+) -> Result<Arc<dyn Array + 'static>>
where
T: ArrayAccessor<Item = ArrayRef>,
+ P: ArrowPrimitiveType,
{
- let elem_type = match list_array.data_type() {
+ let _elem_type = match list_array.data_type() {
Review Comment:
Look like it's useless, we can remove it🤔.
##########
datafusion/core/src/physical_plan/unnest.rs:
##########
@@ -425,11 +435,16 @@ where
/// ```ignore
/// 1, null, 2, 3, 4, null, 5, 6
/// ```
-fn unnest_array<T>(list_array: &T) -> Result<Arc<dyn Array + 'static>>
+fn unnest_array<T, P>(
+ list_array: &T,
+ list_array_values: &Arc<dyn Array>,
+ list_lengths: &PrimitiveArray<P>,
+) -> Result<Arc<dyn Array + 'static>>
where
T: ArrayAccessor<Item = ArrayRef>,
+ P: ArrowPrimitiveType,
{
- let elem_type = match list_array.data_type() {
+ let _elem_type = match list_array.data_type() {
Review Comment:
Look like it's useless, we can remove it🤔.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
