jorisvandenbossche commented on PR #36743: URL: https://github.com/apache/arrow/pull/36743#issuecomment-1639870371
> aren't the changes on setup.py required? No idea what this `setup_requires` is actually still doing (now there is pyproject.toml), we should probably check to remove that. It's not really "required", but indeed nicer to update the error message (it would also have been clearer on the conda build). On the other hand, I am not sure it is necessary to fully disallow building with cython 3, for example for local development. But assuming we remove the pin soon again on the main branch, I added it for now. > [about conda env] We should pin Cython there too We actually shouldn't, if we would update our install commands in CI to use pip instead of calling setup.py directly. But that's for another issue ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
