wgtmac commented on code in PR #36510:
URL: https://github.com/apache/arrow/pull/36510#discussion_r1267015349
##########
cpp/src/parquet/file_reader.cc:
##########
@@ -66,7 +66,8 @@ static constexpr int64_t kMaxDictHeaderSize = 100;
RowGroupReader::RowGroupReader(std::unique_ptr<Contents> contents)
: contents_(std::move(contents)) {}
-std::shared_ptr<ColumnReader> RowGroupReader::Column(int i) {
+std::shared_ptr<ColumnReader> RowGroupReader::Column(
+ int i, std::optional<ReaderProperties> prop) {
Review Comment:
Is it an overkill to setup a column-level buffer size of each row group? If
you really need control in this granularity, you can create one reader for each
row group. Probably enabling buffered stream in this case is not a good idea as
its behavior is not that predicable.
ReaderProperties is immutable once reader has been created, mutating it
seems not a good idea to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
