thorfour commented on issue #36671: URL: https://github.com/apache/arrow/issues/36671#issuecomment-1640928301
@zeroshade I spun my wheels for a few days on a generic implementation that didn't change any code logic. However I was unable to come up with one that worked. I got really close in [this branch](https://github.com/thorfour/arrow/tree/go-generic-memotable) but ultimately couldn't get it to work with the util function `GetDictArrayData` that casts the memo table to it's underlying type (apparently doesn't work well with typed generics). I think it still should be doable but it's going to require a larger rewrite and/or potentially a redesigned memotable that uses the same underling logic for all types. For now I opened a draft PR with my original implementation which just changes the `BinaryMemoTable` to use a byte specific implementation instead of `interface{}`. Curious to get your thoughts on the best approach forward here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
