jayzhan211 commented on code in PR #7008:
URL: https://github.com/apache/arrow-datafusion/pull/7008#discussion_r1268001289
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -464,12 +479,16 @@ impl BuiltinScalarFunction {
},
BuiltinScalarFunction::ArrayConcat => {
let mut expr_type = Null;
+ let mut max_dims = 1;
Review Comment:
I think max_dims should be 0, If all the list is 1D, we will get null for
expr_type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
